----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15966/#review29696 -----------------------------------------------------------
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandlerFactory.java <https://reviews.apache.org/r/15966/#comment57145> This is not required. trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandlerFactory.java <https://reviews.apache.org/r/15966/#comment57146> you can just return a new FSLauncherURIHandler() here as you already know the class instead of moving instantiation by reflection from else block to the end. - Rohini Palaniswamy On Dec. 4, 2013, 1:10 a.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15966/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2013, 1:10 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1630 > https://issues.apache.org/jira/browse/OOZIE-1630 > > > Repository: oozie > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1630 > > > Diffs > ----- > > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFSPrepareActions.java > 1547202 > > trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandlerFactory.java > 1547202 > > Diff: https://reviews.apache.org/r/15966/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
