[ 
https://issues.apache.org/jira/browse/OOZIE-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840625#comment-13840625
 ] 

Robert Kanter commented on OOZIE-1575:
--------------------------------------

For #6 above, {{otherArgs}} is added to, but never read from.  It should be 
safe to remove it because nothing's actually using it.

A few additional trivial things:
# {{XOozieClient#serializeSqoopCommand}} line 108 is missing a space
# {{XOozieClient#submitSqoop}} throws an exception mentioning a "commandFile"; 
it should just be "command"
# Add the {{@Override}} thing to the appropriate methods in the 
{{SubmitHttpXCommand}} subclasses
# Unused import in {{SubmitScriptLanguageXCommand}}
# {{TestWorkflowXClient#testSubmitSqoop}} writes a sqoop command file that's 
not actually used; it should be removed
# In {{TestSubmitSqoopXCommand}} there should be a new line between the imports 
and the class declaration


> Add functionality to submit sqoop jobs through http on oozie server side
> ------------------------------------------------------------------------
>
>                 Key: OOZIE-1575
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1575
>             Project: Oozie
>          Issue Type: Sub-task
>          Components: client
>            Reporter: Bowen Zhang
>            Assignee: Bowen Zhang
>             Fix For: trunk
>
>         Attachments: oozie-1575.patch, oozie-1575.patch, oozie-1575.patch, 
> oozie-1575.patch, oozie-1575.patch, oozie-1575.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to