[ 
https://issues.apache.org/jira/browse/OOZIE-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846559#comment-13846559
 ] 

Robert Kanter commented on OOZIE-1576:
--------------------------------------

A few comments:
- The part where you show the arguments as the output of the help command on 
the CLI page can be longer than 132 characters to be consistent with the actual 
output.
-- Same with the example later on
-- And in the REST API page, it didn't render the description of 
{{oozie.sqoop.options.n}} properly for the same reason (you can't line wrap 
bullet points)
- Is "everything after '-X' are pass-through parameters to sqoop" correct?  We 
have the {{-command}} argument that takes the command that gets passed to 
Sqoop.  Is there anything else that gets passed to Sqoop with the {{-X}}?  I 
think only the {{-D}} arguments after {{-X}} are valid, right?
-- The equivalent argument in the REST API is {{oozie.sqoop.options}}.  You 
should add a sentence after this like we do for hive and pig to clarify what it 
is: "The oozie.hive.options.n parameters are sent directly to Hive without any 
modification unless they start with -D , in which case they are put into the 
element of the action."  Though, if we don't actually do pass-through 
arguments, you should rephrase this to only mention the -D stuff.
- I think I must have missed this in the other patch (which is why I usually 
don't like having the documentation be a separate patch), but after the 
{{-config}} argument, it should accept optional multiple {{\[-Dkey=value\]}} 
argument(s) like hive, etc do.  These arguments act the same way as properties 
specified in the job.properties.  

> Add documentation for Oozie Sqoop CLI
> -------------------------------------
>
>                 Key: OOZIE-1576
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1576
>             Project: Oozie
>          Issue Type: Sub-task
>          Components: client
>            Reporter: Bowen Zhang
>            Assignee: Bowen Zhang
>             Fix For: trunk
>
>         Attachments: oozie-1576.patch, oozie-1576.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to