> On Jan. 21, 2014, 1:57 a.m., Robert Kanter wrote: > > core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java, lines > > 224-225 > > <https://reviews.apache.org/r/16756/diff/2/?file=419913#file419913line224> > > > > I think we should switch the logic around to be consistent with the log > > streaming. > > > > i.e. > > if(... == null || ... == "true") > > > > This way, it will default to doing it for all servers unless the > > parameter is explicitly set to false.
Added a common method isAllServerRequest() to check if request is for all server. Make default as true is a risk, a typo can cause system to hang( with recursive calls). I have kept default as true and if needed we can change it later on. Now we have logic in one function and all should use that. > On Jan. 21, 2014, 1:57 a.m., Robert Kanter wrote: > > core/src/main/java/org/apache/oozie/util/AuthUrlClient.java, line 39 > > <https://reviews.apache.org/r/16756/diff/2/?file=419914#file419914line39> > > > > Moving these things into their own class was a good idea and is cleaner > > than what I had originally :) > > > > But I think we should make this a static class or a singleton. The > > authenticator class type shouldn't change without restarting Oozie, so once > > we call determineAuthenticatorClassType() it shouldn't change; this class > > also has no other state, so its methods can all be made static so callers > > don't have to instantiate an AuthUrlClient object to use these them. > > Agree, made as static class. - Purshotam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16756/#review32335 ----------------------------------------------------------- On Jan. 22, 2014, 7 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16756/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 7 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1609 > https://issues.apache.org/jira/browse/OOZIE-1609 > > > Repository: oozie-git > > > Description > ------- > > Sharelib support for HA. > > 1.Sharelib update : Server calls other server to update sharelib. > 2.Purging of sharelib : only first server deletes sharelib. > > > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/client/OozieClient.java 9d6c9e0 > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > f65239d > core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java > 99c16e0 > core/src/main/java/org/apache/oozie/service/ShareLibService.java 9556620 > core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java > 42fce05 > core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java > c17a8aa > core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java 091070f > core/src/main/java/org/apache/oozie/util/AuthUrlClient.java e69de29 > core/src/test/java/org/apache/oozie/service/DummyV2AdminServlet.java > e69de29 > core/src/test/java/org/apache/oozie/service/TestHAShareLibService.java > e69de29 > docs/src/site/twiki/DG_CommandLineTool.twiki af472d3 > docs/src/site/twiki/WebServicesAPI.twiki 50795b4 > > Diff: https://reviews.apache.org/r/16756/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
