----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16998/#review32636 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/CoordinatorEngine.java <https://reviews.apache.org/r/16998/#comment61525> No need for looping, you can get size of list and validate. core/src/main/java/org/apache/oozie/CoordinatorEngine.java <https://reviews.apache.org/r/16998/#comment61526> No need for looping, you can get size of set and validate. core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java <https://reviews.apache.org/r/16998/#comment61522> Minor comment. In almost all case we throw ErrorCode E0302. It good to validate error message as well, to make sure that it's failing for right reason. webapp/src/main/webapp/oozie-console.js <https://reviews.apache.org/r/16998/#comment61521> Max count is hardcoded here. Change is conf file doesn't reflect here. - Purshotam Shah On Jan. 23, 2014, 5:39 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16998/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2014, 5:39 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1671 > https://issues.apache.org/jira/browse/OOZIE-1671 > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1671 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 57587c2 > core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java > a29a07e > webapp/src/main/webapp/oozie-console.js 7999d35 > > Diff: https://reviews.apache.org/r/16998/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
