----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16981/#review32755 -----------------------------------------------------------
Ship it! Minor changes. Will +1 in jira after the updated patch passes jenkins core/src/main/java/org/apache/oozie/service/LiteWorkflowAppService.java <https://reviews.apache.org/r/16981/#comment61718> return parseDef(jobConf, null) core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java <https://reviews.apache.org/r/16981/#comment61721> Move this before the method with three args - Rohini Palaniswamy On Jan. 24, 2014, 8:39 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16981/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2014, 8:39 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1644 > https://issues.apache.org/jira/browse/OOZIE-1644 > > > Repository: oozie-git > > > Description > ------- > > See JIRA https://issues.apache.org/jira/browse/OOZIE-1644 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 433737a > core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java a81bf10 > core/src/main/java/org/apache/oozie/service/LiteWorkflowAppService.java > 40eeeff > core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 81535a4 > core/src/main/java/org/apache/oozie/workflow/WorkflowLib.java d32f770 > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java > 31852b4 > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowLib.java > 12f7ed0 > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > a250c8c > > sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java > 00f0261 > > Diff: https://reviews.apache.org/r/16981/diff/ > > > Testing > ------- > > unit test + e-2-e test done > > > Thanks, > > Mona Chitnis > >
