-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17371/#review33015
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/17371/#comment62144>

    can you also check port number existence, otherwise no need to convert to 
path component. 


- Ryota Egashira


On Jan. 26, 2014, 5:23 p.m., Satish Mittal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17371/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2014, 5:23 p.m.)
> 
> 
> Review request for oozie and Ryota Egashira.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> - Attaching the patch that fixes the issue
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> 133d6a2 
>   
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 
> aede93f 
> 
> Diff: https://reviews.apache.org/r/17371/diff/
> 
> 
> Testing
> -------
> 
> - Ran Unit tests; added new unit test
> - Tested the functionality with hadoop-1 and oozie-4
> 
> 
> Thanks,
> 
> Satish Mittal
> 
>

Reply via email to