> On Jan. 30, 2014, 10:37 p.m., Mona Chitnis wrote: > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, > > line 589 > > <https://reviews.apache.org/r/16203/diff/2/?file=396840#file396840line589> > > > > the JIRA description mentions "oozie.action.sharelib.exclusion", and > > the string differs here. Why do we need exclusion per type?
Currently sharelib is specified as String actionShareLibProperty = actionConf.get(ACTION_SHARELIB_FOR + getType()); I think it's better to provide exclusion in similar way. User can just add suffix (.exclusion) to specify exclusion for sharelib. Will modify the jira accordingly. - Purshotam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16203/#review33267 ----------------------------------------------------------- On Dec. 12, 2013, 6:23 a.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16203/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2013, 6:23 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1624 > https://issues.apache.org/jira/browse/OOZIE-1624 > > > Repository: oozie > > > Description > ------- > > OOZIE-1624 Exclusion pattern for sharelib. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1550348 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestShareLibService.java > 1550348 > > http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/WorkflowFunctionalSpec.twiki > 1550348 > > Diff: https://reviews.apache.org/r/16203/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
