----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/#review33709 -----------------------------------------------------------
Earlier if I recall correctly, we were doing confirmWithDB() only for end miss notification. Now in HA setup, it should be done for any kind of miss computation. Make sure it is done before sending our START_MISS and DURATION_MISS as well core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/17720/#comment63317> check whether you can get all the required information from the SLASummaryBean itself to construct required SLACalcStatus object, instead of 2 DB queries core/src/test/java/org/apache/oozie/test/ZKXTestCase.java <https://reviews.apache.org/r/17720/#comment63318> remove this print statement in final patch - Mona Chitnis On Feb. 4, 2014, 8:03 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17720/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2014, 8:03 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1678 > https://issues.apache.org/jira/browse/OOZIE-1678 > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1678 > > > Diffs > ----- > > > core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java > e3b115f > core/src/main/java/org/apache/oozie/service/JPAService.java aba8709 > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 > core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java a2260a4 > > core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java > 00fb677 > core/src/test/java/org/apache/oozie/service/TestHASLAService.java > PRE-CREATION > core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 > > Diff: https://reviews.apache.org/r/17720/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
