> On March 3, 2014, 7:24 a.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java, > > line 174 > > <https://reviews.apache.org/r/18653/diff/2/?file=507582#file507582line174> > > > > Shouldn't the hadoop team be naming it as yarn.application.tags as it > > is not mapreduce specific but yarn specific? Can you check with Karthik > > Kambatla about the naming of the config? Don't want it to be deprecated > > soon and renamed.
YARN doesn't know about this config. The config is just a convenience in MR, and is used to set the corresponding field in ApplicationSubmissionContext (ASC). So, if a different AM (may be Oozie AM - that would be cool :)) uses this config, it has no effect unless the AM implements applying this config to the ASC. I don't see a risk of the config being deprecated/renamed. - Karthik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18653/#review35945 ----------------------------------------------------------- On March 1, 2014, 2:01 a.m., Robert Kanter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18653/ > ----------------------------------------------------------- > > (Updated March 1, 2014, 2:01 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1722 > https://issues.apache.org/jira/browse/OOZIE-1722 > > > Repository: oozie-git > > > Description > ------- > > See https://issues.apache.org/jira/browse/OOZIE-1722 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 68d77a8 > core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java > 07de214 > core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java b55b9d7 > hadooplibs/hadoop-utils-0.23/pom.xml PRE-CREATION > > hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > PRE-CREATION > hadooplibs/hadoop-utils-1/pom.xml PRE-CREATION > > hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > PRE-CREATION > hadooplibs/hadoop-utils-2/pom.xml PRE-CREATION > > hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > PRE-CREATION > hadooplibs/hadoop-utils-3/pom.xml PRE-CREATION > > hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > PRE-CREATION > hadooplibs/pom.xml 35875c8 > pom.xml 1223ec2 > sharelib/hive/pom.xml e355d97 > sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java > 8fa5ec8 > sharelib/oozie/pom.xml c70582d > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > b5fa4a1 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/MapReduceMain.java > 6230e64 > sharelib/pig/pom.xml a2bbeaf > sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java > 9c1e659 > sharelib/sqoop/pom.xml a962565 > sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java > e45c8b2 > > Diff: https://reviews.apache.org/r/18653/diff/ > > > Testing > ------- > > > Thanks, > > Robert Kanter > >
