----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18653/#review36163 -----------------------------------------------------------
Patch is good. Just one minor variable name change comment. Will do final +1 after a decision on distcp based on whether you are able to get it working with (2a) or (3) or we have to go with (1) with no support for tags for distcp action. core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/18653/#comment67083> actionConf core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java <https://reviews.apache.org/r/18653/#comment67087> Unintended revert of earlier checkin release-log.txt <https://reviews.apache.org/r/18653/#comment67082> Unintended revert of earlier checkin - Rohini Palaniswamy On March 4, 2014, 3:11 a.m., Robert Kanter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18653/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 3:11 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1722 > https://issues.apache.org/jira/browse/OOZIE-1722 > > > Repository: oozie-git > > > Description > ------- > > See https://issues.apache.org/jira/browse/OOZIE-1722 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/DistcpActionExecutor.java > fcf69e7 > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 68d77a8 > core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java > 07de214 > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 7841076 > core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java b55b9d7 > core/src/test/java/org/apache/oozie/service/TestShareLibService.java > e7d7a26 > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > 41e6205 > hadooplibs/hadoop-utils-0.23/pom.xml PRE-CREATION > > hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > PRE-CREATION > hadooplibs/hadoop-utils-1/pom.xml PRE-CREATION > > hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > PRE-CREATION > hadooplibs/hadoop-utils-2/pom.xml PRE-CREATION > > hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > PRE-CREATION > hadooplibs/hadoop-utils-3/pom.xml PRE-CREATION > > hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > PRE-CREATION > hadooplibs/pom.xml 35875c8 > pom.xml 1223ec2 > release-log.txt f6810bc > > sharelib/distcp/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java > 25b1a23 > sharelib/hive/pom.xml e355d97 > sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java > 8fa5ec8 > sharelib/oozie/pom.xml c70582d > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/JavaMain.java > PRE-CREATION > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > b5fa4a1 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/MapReduceMain.java > 6230e64 > sharelib/pig/pom.xml a2bbeaf > sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java > 9c1e659 > sharelib/sqoop/pom.xml a962565 > sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java > e45c8b2 > > sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/18653/diff/ > > > Testing > ------- > > > Thanks, > > Robert Kanter > >
