----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18569/#review37254 -----------------------------------------------------------
LGTM. Can you add a unit test to check launcher's hdfs dir contents? - Mona Chitnis On Feb. 27, 2014, 8:02 a.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18569/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2014, 8:02 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1713 > https://issues.apache.org/jira/browse/OOZIE-1713 > > > Repository: oozie-git > > > Description > ------- > > In current approach we create a dummy input file for each launcher jobs, > which puts extra load on NN. > Cleaner approach is to define a Oozie launcher input format which can works > without input file. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 68d77a8 > core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java > 07de214 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/OozieLauncherInputFormat.java > e69de29 > > Diff: https://reviews.apache.org/r/18569/diff/ > > > Testing > ------- > > No need for adding extra testcase. All Workflow job will use this feature. > > > Thanks, > > Purshotam Shah > >
