----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19429/#review37884 -----------------------------------------------------------
You should be able to turn on compression with tomcat by just configuring settings - http://viralpatel.net/blogs/enable-gzip-compression-in-tomcat/ and this patch is not required at all. Even if that had issues and you need to implement that in the java code you should be doing it as a Servlet Filter and wrap your response outputstream there with a Compressor (http://learningviacode.blogspot.com/2012/11/gzip-your-tomcat-response.html). Modifying places in Oozie code is not good and the current patch also will not handle the html responses or the log streaming. i.e anything not going through JsonServlet will be uncompressed. - Rohini Palaniswamy On March 19, 2014, 11:19 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19429/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 11:19 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1747 > https://issues.apache.org/jira/browse/OOZIE-1747 > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1747 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java 29d7bd6 > core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 31e9d2f > core/src/main/java/org/apache/oozie/servlet/BaseJobsServlet.java 41c17ae > core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java ab82811 > core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 6052d23 > core/src/test/java/org/apache/oozie/servlet/TestV1JobsServlet.java 2df009c > docs/src/site/twiki/WebServicesAPI.twiki 4b20075 > > Diff: https://reviews.apache.org/r/19429/diff/ > > > Testing > ------- > > locally tested > > > Thanks, > > Ryota Egashira > >
