> On March 20, 2014, 11:31 p.m., Rohini Palaniswamy wrote:
> > client/src/main/java/org/apache/oozie/client/rest/JsonTags.java, line 231
> > <https://reviews.apache.org/r/19491/diff/1/?file=530492#file530492line231>
> >
> >     String instead of Object
> >     
> >     COORD_ACTION_WORKFLOWS

removed this since going with reusing JsonTags.WORKFLOW_JOBS


> On March 20, 2014, 11:31 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java, line 230
> > <https://reviews.apache.org/r/19491/diff/1/?file=530497#file530497line230>
> >
> >     Can we use show=allworkflows/workflows instead of introducing a new 
> > query param?

hmm will have to rework using job id as coord action id now since I was using 
the new query param to pass the action number
e.g. oozie/v1/job/coordid@1?show=allworkflows


- Mona


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19491/#review37996
-----------------------------------------------------------


On March 20, 2014, 8:36 p.m., Mona Chitnis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19491/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 8:36 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1746
>     https://issues.apache.org/jira/browse/OOZIE-1746
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> OOZIE-1746
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/oozie/cli/OozieCLI.java 3c780dd 
>   client/src/main/java/org/apache/oozie/client/OozieClient.java b0a85fd 
>   client/src/main/java/org/apache/oozie/client/rest/JsonTags.java ae391c7 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 0466ffe 
>   core/src/main/java/org/apache/oozie/CoordinatorEngine.java 315a330 
>   core/src/main/java/org/apache/oozie/WorkflowJobBean.java 3194995 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java
>  e60e009 
>   core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 31e9d2f 
>   core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java d080d3c 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 2ef351e 
>   core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 72265c8 
>   
> core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromCoordParentIdJPAExecutor.java
>  dcf83ad 
>   core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java 6f5a172 
>   webapp/src/main/webapp/oozie-console.js 2742485 
> 
> Diff: https://reviews.apache.org/r/19491/diff/
> 
> 
> Testing
> -------
> 
> unit test + end-to-end done
> 
> 
> Thanks,
> 
> Mona Chitnis
> 
>

Reply via email to