----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19520/#review38146 -----------------------------------------------------------
One concern I have is that these changes are adding more restrictions on how the user can configure log4j, right? We've seen pushback from users on the current set of restrictions (e.g. log file rolls every hour, using OozieRollingPolicy only, etc). Also, we should document the new restrictions if we go forward with them; though ideally, we can maybe make them less restrictive instead? core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java <https://reviews.apache.org/r/19520/#comment70113> The exact same code is re-used again later in XLogStreamer; can we make a method somewhere instead? - Robert Kanter On March 21, 2014, 4:55 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19520/ > ----------------------------------------------------------- > > (Updated March 21, 2014, 4:55 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1737 > https://issues.apache.org/jira/browse/OOZIE-1737 > > > Repository: oozie-git > > > Description > ------- > > User can provide multiple option as -param <>;<>;<> to make streaming faster > and precise. > Option can be. > * Recent: Define offset of recent hours/Min of log to stream. Server will > search user query only in recent log duration. > * Start: Start time of log parsing. Oozie server will start parsing logs > from start date. User can provide a valid date or > offset. > * End: Server will streaming logs till specified end date. User can > provide a valid date or offset. > * Loglevel : Multiple log levels separated by "|" can be specified. > * Text: String to search in logs. > * Limit : Limit number of line to be searched. Log search will end when > when n lines(excluding exception) of patten has > matched. > * Debug : Will print log start and end time. This will be useful, if user > are not sure what his/her offset will be > calculated to. > > > In addition to this > 1. System setting to control log streaming duration. > 2. Added a option to show log streaming status. > A label on UI will show if log streaming is in progress, completed or > erred. > 3. Many user has complied that get button doesn't look like button. Changes > the look of "get log" button. > 4. End the execution when data is date is reached. > earlier started date and end date is only used to load logs files. > ...... > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java 3c780dd > client/src/main/java/org/apache/oozie/client/OozieClient.java b0a85fd > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 0466ffe > core/src/main/java/org/apache/oozie/BundleEngine.java ce7c9c4 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 315a330 > core/src/main/java/org/apache/oozie/DagEngine.java 300d6eb > core/src/main/java/org/apache/oozie/service/XLogStreamingService.java > f77794e > core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java > 8dc8b4b > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 2ef351e > core/src/main/java/org/apache/oozie/util/LogUserParam.java e69de29 > core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java > 8a11780 > core/src/main/java/org/apache/oozie/util/XLogStreamer.java bc6b009 > core/src/main/resources/oozie-default.xml 34362aa > core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java > b4f161a > core/src/test/java/org/apache/oozie/service/TestLogStreamingParam.java > e69de29 > core/src/test/resources/userParamTestlog.log e69de29 > docs/src/site/twiki/DG_CommandLineTool.twiki 0748ff8 > webapp/src/main/webapp/oozie-console.js 0b6cedf > > Diff: https://reviews.apache.org/r/19520/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
