-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19855/
-----------------------------------------------------------

Review request for oozie.


Bugs: OOZIE-1761
    https://issues.apache.org/jira/browse/OOZIE-1761


Repository: oozie-git


Description
-------

Currently oozie server purges anything older then 7 
(oozie.ShareLibService.temp.sharelib.retention.days) days, keeping 2 latest dir.
Which might be faulty.
Take an example.
Currently used sharelib is sharelib-1, which is created a month before.
If I restart Oozie server 2 times, it will create directory sharelib-2 and 
sharelib-3 and delete anything older than 7 days( keeping two latest).
In this case oozie server will delete sharelib-1, which is wrong and all 
running jobs will start failing.
Better logic is to keep all share-lib between current timestamp and 7days old + 
1 latest sharelib older than 7 days.


Diffs
-----

  core/src/main/java/org/apache/oozie/service/ShareLibService.java 89939f1 
  core/src/test/java/org/apache/oozie/service/TestShareLibService.java e7d7a26 

Diff: https://reviews.apache.org/r/19855/diff/


Testing
-------


Thanks,

Purshotam Shah

Reply via email to