----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20451/#review40782 -----------------------------------------------------------
client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/20451/#comment73923> isn't ignore a switch? What will be the getOptionValue() of it? Please pass range type and scope, so that we can add -date option in future in addition to -action similar to other commands. client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/20451/#comment73924> Accidental change. To be reverted/ core/src/main/java/org/apache/oozie/BundleActionBean.java <https://reviews.apache.org/r/20451/#comment73946> Can you rename them appropriately? GET_*_STATUS_UNIGNORED GET_BUNDLE_ACTIONS_FOR_BUNDLE is used by almost all bundle commands. Can we add a note in documentation to change endtime/pausetime of bundle that ignored coordinators will not be changed when setting endtime/pausetime. Also suspend, resume, kill will not affect them. core/src/main/java/org/apache/oozie/BundleEngine.java <https://reviews.apache.org/r/20451/#comment73925> To be removed core/src/main/java/org/apache/oozie/CoordinatorActionBean.java <https://reviews.apache.org/r/20451/#comment73947> Can be avoided and handled in StatusTransitService or change name of the query to GET_COORD_ACTIONS_STATUS_UNIGNORED. core/src/main/java/org/apache/oozie/CoordinatorEngine.java <https://reviews.apache.org/r/20451/#comment73926> CoordActionIgnoreXCommand - consistent naming core/src/main/java/org/apache/oozie/ErrorCode.java <https://reviews.apache.org/r/20451/#comment73927> run core/src/main/java/org/apache/oozie/command/IgnoreTransitionXCommand.java <https://reviews.apache.org/r/20451/#comment73951> To be removed. Please do not add non-Javadoc comments. If possible remove existing ones in your patches. core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java <https://reviews.apache.org/r/20451/#comment73953> Log messages should be info. We need to propagate status back to user. Please make it a synchronous call to command in the JobServlet and return a String like CoordChangeXCommand. core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java <https://reviews.apache.org/r/20451/#comment73937> The conditions should have || inside and a single ! outside. core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java <https://reviews.apache.org/r/20451/#comment73933> Just implement in v2. Not in v1. core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java <https://reviews.apache.org/r/20451/#comment73932> else ? docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/20451/#comment73930> PAUSED ? docs/src/site/twiki/WebServicesAPI.twiki <https://reviews.apache.org/r/20451/#comment73928> type=action, so that we can have date in the future - Rohini Palaniswamy On April 18, 2014, 4:43 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20451/ > ----------------------------------------------------------- > > (Updated April 18, 2014, 4:43 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1791 > https://issues.apache.org/jira/browse/OOZIE-1791 > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1791 > > WIP, just to show design, need to add test case and proper error handling, > etc.. > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java e3eb3b0 > client/src/main/java/org/apache/oozie/client/CoordinatorAction.java a0e42cd > client/src/main/java/org/apache/oozie/client/Job.java 8533165 > client/src/main/java/org/apache/oozie/client/OozieClient.java 40c9562 > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > a7fe06e > core/src/main/java/org/apache/oozie/BundleActionBean.java 607f55b > core/src/main/java/org/apache/oozie/BundleEngine.java 5bf1538 > core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 03a7ed8 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 6a17ce4 > core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5eb134b > core/src/main/java/org/apache/oozie/ErrorCode.java f69d7a2 > core/src/main/java/org/apache/oozie/command/IgnoreTransitionXCommand.java > PRE-CREATION > core/src/main/java/org/apache/oozie/command/bundle/BundleJobXCommand.java > 2ddfbdb > > core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java > PRE-CREATION > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java > fb31e9a > core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java > 2e5f6b4 > core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java > 0db2dad > core/src/main/java/org/apache/oozie/coord/CoordUtils.java 0319942 > core/src/main/java/org/apache/oozie/service/RecoveryService.java 2749bc4 > core/src/main/java/org/apache/oozie/service/StatusTransitService.java > e093c7d > core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java aa43e68 > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java ac399e9 > docs/src/site/twiki/DG_CommandLineTool.twiki 5819b71 > docs/src/site/twiki/WebServicesAPI.twiki 351699d > > Diff: https://reviews.apache.org/r/20451/diff/ > > > Testing > ------- > > Not yet > > > Thanks, > > Ryota Egashira > >
