----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20562/#review41052 -----------------------------------------------------------
Can we delete CoordActionsActiveCountJPAExecutor and replace with QueryExecutor? Need to copy over test from TestCoordActionsActiveCountJPAExecutor and delete that as well. core/src/main/java/org/apache/oozie/CoordinatorJobBean.java <https://reviews.apache.org/r/20562/#comment74425> Can you add a TODO comment to remove when we get rid of CoordinatorStore core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java <https://reviews.apache.org/r/20562/#comment74428> Remove the constructor or refer to the other constructor passing the default value. If not removing the constructor, order the constructors in the order of increasing arguments. core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java <https://reviews.apache.org/r/20562/#comment74426> getMaterializationTimeForCatchUp core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java <https://reviews.apache.org/r/20562/#comment74439> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java <https://reviews.apache.org/r/20562/#comment74436> Instance core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java <https://reviews.apache.org/r/20562/#comment74443> formatting core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java <https://reviews.apache.org/r/20562/#comment74446> materialization - Rohini Palaniswamy On April 22, 2014, 7:32 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20562/ > ----------------------------------------------------------- > > (Updated April 22, 2014, 7:32 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1527 > https://issues.apache.org/jira/browse/OOZIE-1527 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-1527 Fix scalability issues with coordinator materialization > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 4a2ea39 > > core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > b483799 > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java > 67a919d > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsToBeMaterializedJPAExecutor.java > ca11a24 > > core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java > 550eb80 > core/src/main/resources/oozie-default.xml 0198230 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 6c73585 > > core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java > 9d4bd3b > > Diff: https://reviews.apache.org/r/20562/diff/ > > > Testing > ------- > > UTC > > > Thanks, > > Purshotam Shah > >
