[ 
https://issues.apache.org/jira/browse/OOZIE-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980516#comment-13980516
 ] 

Bowen Zhang commented on OOZIE-1319:
------------------------------------

By spotting your patch, I see two things.
*  By definition, "execution order" means "the execution order if multiple 
instances of the coordinator job have satisfied their execution criteria" which 
means instances that fulfill both data and time dependency and ready to run. 
You added the "handleLastOnly()" in CoordMaterializeTransitionXCommand which 
changes the logic of regular materialization. After your changes, any 
coordinator job with "LAST_ONLY" execution will only execute the last action in 
EACH MATERIALIZATION WINDOW. For example, suppose right now is 9am and I submit 
a coordinator job with "LAST_ONLY" and 10 minutes frequency which starts at 10 
am and ends at 1pm. As a result, among all the 18 actions, only actions with 
nominal time of 10:50am, 11:50am, and 12:50pm will run. All the others will be 
SKIPPED. That is not correct behavior.
* We should not create JPAExecutor class anymore. Your query name 
"GET_UNSCHEDULED_ACTIONS" should be put into CoordActionQueryExecutor.java.

> "LAST_ONLY" in execution control for coordinator job still runs all the 
> actions
> -------------------------------------------------------------------------------
>
>                 Key: OOZIE-1319
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1319
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Bowen Zhang
>            Assignee: Robert Kanter
>         Attachments: OOZIE-1319.patch, OOZIE-1319.patch, OOZIE-1319.patch, 
> oozie-1319.patch
>
>
> In execute() of CoordJobGetReadyActionsJPAExecutor.java, once we retrieve the 
> top item from a "LIFO" query result, we do not discard or delete the 
> remaining items from the result list. As a result, the next time execute() is 
> invoked, we will be retrieving the next item in line. Consequently, LAST_ONLY 
> strategy will also execute all ready actions for a given coordinator job, 
> making it no different than LIFO.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to