----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21654/#review43542 -----------------------------------------------------------
Ship it! Just a minor comment to fix before uploading to jira. core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java <https://reviews.apache.org/r/21654/#comment77752> private - Rohini Palaniswamy On May 19, 2014, 8:15 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21654/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 8:15 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1844 > https://issues.apache.org/jira/browse/OOZIE-1844 > > > Repository: oozie-git > > > Description > ------- > > Other services like StatusTransitService, PauseTransitService already acquire > lock before running. > > RecoveryService queues all command, lock technique may not work for queuing > command. Will skip it for the time being. It ok for RecoveryService to use > modulus operation as it doesn't contribute much load. > > > Diffs > ----- > > > core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java > ef3c3f4 > > Diff: https://reviews.apache.org/r/21654/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
