In that case, it is an issue. Can someone else also make comments about the impact of removing the "factory.destroy()"? I know the Oozie team at Y! made substantial investigations in the DB access layer.
Regards, Mohammad On Monday, June 9, 2014 4:44 PM, bowen zhang <[email protected]> wrote: Mohammad, there is no code insuring all active transactions are closed. On Monday, June 9, 2014 2:53 PM, Mohammad Islam <[email protected]> wrote: Bowen, This has been done a long time back. I can't recall the full context. However, it is better to make sure all transactions are completed before closing it. Is there a way to do that? This will be a safer approach. Deleting the line looks little risky. We need to close the factory. right? Will it keep some resource leaking? If we can find any references that it is not required, we can delete the line. Regards, Mohammad On Monday, June 9, 2014 2:33 PM, bowen zhang <[email protected]> wrote: Hi Mohammad, I saw you wrote the line "factory.close()" in the destroy method of JPAService.java. I've seen some issues of this line throwing invalidStateException while there is active transaction happening, particularly on Windows. Can you tell me how you make sure there is no active transaction when shutting down oozie? Should this line be deleted? Thanks,Bowen
