[
https://issues.apache.org/jira/browse/OOZIE-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14027094#comment-14027094
]
Robert Kanter commented on OOZIE-1654:
--------------------------------------
{quote}It doesn't make sense to have different default value in oozie-default
and code. We should fix them.{quote}
I agree; that just makes things confusing for us and the user.
{quote} have seen cases where the configs(read in code) are not mentioned in
oozie-default.... So, didn't think that oozie-default.xml is the documentation
of available configs.{quote}
Ideally, all configs should be in oozie-default.xml; it is used for
documentation. However, we don't always remember to do that.
I think we should put CONF_USER_RETRY_INTERVAL in oozie-default because it's
the correct property name. However, I think we need to make
CONF_USER_RETRY_INTEVAL have priority. Otherwise, if the user specifies
CONF_USER_RETRY_INTEVAL in oozie-site, it won't override the setting of
CONF_USER_RETRY_INTERVAL in oozie-default.
I think what we want is this:
{code:java}
int ret = conf.getInt(CONF_USER_RETRY_INTEVAL,
conf.get(CONF_USER_RETRY_INTERVAL, 5));
{code}
(and 5, or whatever we put there, would be what CONF_USER_RETRY_INTERVAL is set
to in oozie-default)
With this code, if the user has already specified CONF_USER_RETRY_INTEVAL in
their oozie-site, it will use that. Otherwise, it will use
CONF_USER_RETRY_INTERVAL if the user specifies that or CONF_USER_RETRY_INTERVAL
from oozie-default if not (and if somehow oozie-default is missing it, it will
use the last value, 5).
Do you agree?
> Fix typo (inteval to interval)
> ------------------------------
>
> Key: OOZIE-1654
> URL: https://issues.apache.org/jira/browse/OOZIE-1654
> Project: Oozie
> Issue Type: Improvement
> Components: action
> Affects Versions: 4.0.0
> Reporter: Azrael
> Priority: Trivial
> Attachments: OOZIE-1654.1.patch, OOZIE-1654.patch
>
>
> Fix typo inteval to interval.
> oozie-default.xml
> {code:xml}
> <name>oozie.service.LiteWorkflowStoreService.user.retry.inteval</name>
> >>> to
> <name>oozie.service.LiteWorkflowStoreService.user.retry.interval</name>
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
