-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22491/#review45580
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
<https://reviews.apache.org/r/22491/#comment80482>

    3600 is MATERIALIZATION_WINDOW, we have configuration for that. Please use 
that.
    
    
    
    CoordMaterializeTriggerService
    int materializationWindow = conf.getInt(CONF_MATERIALIZATION_WINDOW, 
CONF_MATERIALIZATION_WINDOW_DEFAULT);
    



core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
<https://reviews.apache.org/r/22491/#comment80483>

    Can you please change this as well.
    
    Replace 3600 as MATERIALIZATION_WINDOW conf, once you do that you can close 
OOZIE-1845.
    
    
    
    


- Purshotam Shah


On June 13, 2014, 7:05 a.m., Azrael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22491/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 7:05 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1846
>     https://issues.apache.org/jira/browse/OOZIE-1846
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> Use CoordActionMaterializeCommand for dryrun and remove Command.
> 
> Change surefire version to 2.12.2 for single method test.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/command/Command.java d3f1011 
>   core/src/main/java/org/apache/oozie/command/CommandException.java ce5ef54 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java
>  6962fb2 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
>  515e247 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
> 91fb5da 
>   core/src/main/java/org/apache/oozie/command/coord/CoordinatorCommand.java 
> c70e171 
>   core/src/test/java/org/apache/oozie/command/TestCommand.java 60363bf 
>   
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java
>  6278515 
>   
> core/src/test/java/org/apache/oozie/command/coord/TestCoordELExtensions.java 
> 7f7a387 
>   
> core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java
>  5b22abc 
>   pom.xml b5e0e4e 
> 
> Diff: https://reviews.apache.org/r/22491/diff/
> 
> 
> Testing
> -------
> 
> Unit test done.
> Manual test done.
> 
> 
> Thanks,
> 
> Azrael Park
> 
>

Reply via email to