----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23223/#review47241 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/service/EventHandlerService.java <https://reviews.apache.org/r/23223/#comment82886> queueEvent is not synchronized. So logging prefix will get mixed up and will only show the last event's job id for all events. Can we also rename method to something like setLogPrefix. core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/23223/#comment82888> Can you make it == 7 ? core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/23223/#comment82889> Not required. Done in processJob*SLA methods - Rohini Palaniswamy On July 2, 2014, 1:11 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23223/ > ----------------------------------------------------------- > > (Updated July 2, 2014, 1:11 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1911 > https://issues.apache.org/jira/browse/OOZIE-1911 > > > Repository: oozie-git > > > Description > ------- > > See JIRA Description from link above > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/service/EventHandlerService.java > 4207a07 > core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java f148db3 > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 47c723d > core/src/main/java/org/apache/oozie/util/LogUtils.java fd5b5b6 > core/src/test/java/org/apache/oozie/service/TestHASLAService.java eec5369 > > Diff: https://reviews.apache.org/r/23223/diff/ > > > Testing > ------- > > new unit test + existing tests pass > > > Thanks, > > Mona Chitnis > >
