[
https://issues.apache.org/jira/browse/OOZIE-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051175#comment-14051175
]
Hadoop QA commented on OOZIE-1890:
----------------------------------
Testing JIRA OOZIE-1890
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:red}-1{color} the patch contains 1 line(s) with trailing spaces
. {color:red}-1{color} the patch contains 2 line(s) longer than 132
characters
. {color:green}+1{color} the patch does adds/modifies 10 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:red}-1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:red}-1{color} the patch seems to introduce 1 new javac warning(s)
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
. Tests run: 1504
. Tests failed: 2
. Tests errors: 1
. The patch failed the following testcases:
.
testConcurrencyReachedAndChooseNextEligible(org.apache.oozie.service.TestCallableQueueService)
.
testActionInputCheckLatestActionCreationTime(org.apache.oozie.command.coord.TestCoordActionInputCheckXCommandNonUTC)
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/1345/
> Make oozie-site empty and reconcile defaults between oozie-default and the
> code
> -------------------------------------------------------------------------------
>
> Key: OOZIE-1890
> URL: https://issues.apache.org/jira/browse/OOZIE-1890
> Project: Oozie
> Issue Type: Bug
> Components: core
> Reporter: Robert Kanter
> Assignee: Azrael
> Attachments: OOZIE-1890.1.patch, OOZIE-1890.2.patch
>
>
> As shwetha and puru suggested in OOZIE-1888, oozie-site vs oozie-default is a
> point of confusion for users. We've also had issues in the past where
> they've had different values from each other and/or from the code's default
> (i.e. {{conf.get(PROP_NAME, DEFAULT_VALUE)}}).
> We should make oozie-default the only source of truth by:
> # Putting all configuration properties in oozie-default.
> # Making oozie-site empty; if the user wants to change a property, they can
> copy it out of the for-reference oozie-default.
> # Getting rid of the code defaults. It's easy for these to be out of sync
> with oozie-default, leading to confusion. They aren't used anyway because
> oozie-default should always be there (and will now have every property)
> This will require looking through all classes to make sure we're not missing
> anything from oozie-default and also checking that we put the proper default
> value (from all 3 sources) into oozie-default. It may be nice to also
> reorder the properties in oozie-default alphabetically (and also do this
> going forward with new properties).
> Also, {{oozie.service.WorkflowAppService.system.libpath}} should be set to
> "/user/$\{user.name\}/share/lib" (which is what OOZIE-1888 wanted to do).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
