[
https://issues.apache.org/jira/browse/OOZIE-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055410#comment-14055410
]
Purshotam Shah commented on OOZIE-1916:
---------------------------------------
+1 for approach, will simplify things.
Looks good.
Minor comment.
{code}
+ if (leaderLatch != null) {
+ IOUtils.closeSafely(leaderLatch);
+ }
{code}
You can use Curator's CloseableUtils
(https://curator.apache.org/apidocs/org/apache/curator/utils/CloseableUtils.html)
to close Closeable.
In future if they need to do housekeeping before closing, it can be done
without any change.
> Use Curator leader latch instead of checking the order of Oozie servers
> -----------------------------------------------------------------------
>
> Key: OOZIE-1916
> URL: https://issues.apache.org/jira/browse/OOZIE-1916
> Project: Oozie
> Issue Type: Improvement
> Components: HA
> Affects Versions: trunk
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Minor
> Attachments: OOZIE-1916.patch
>
>
> We currently have a few tasks (e.g. Purging old jobs) that we only want to do
> in one Oozie server. We currently simply check which Oozie server is first
> in ZooKeeper's list of servers (i.e. the order they connected). We haven't
> seen any problems with this, but it might be a good idea to replace this with
> Curator's leader-latch, which sounds more robust.
> The leader path should probably be something like "/services/leader".
> Make sure errors and edge cases are handled properly, including what happens
> when the leader dies without unregistering, etc.
> http://curator.apache.org/curator-recipes/leader-latch.html
--
This message was sent by Atlassian JIRA
(v6.2#6252)
