> On June 26, 2014, 11:55 p.m., Robert Kanter wrote: > > Great work Abe! I know this wasn't easy to figure out and get working. > > > > I did an initial review and made some comments. I haven't really looked at > > any of the tests yet. > > Also, do we need so many extra txt files for the tests? > > Abraham Elmahrek wrote: > Thanks Robert. I'll try to remove dependencies and see what that does. > > I noticed a mistake in the rules of which arguments are required: > 1. At least one of --zk-host or --solr-home-dir are required. > 2. If solr-home-dir is specified, then --zk-host or --shard-url or > --shards must be specified (mutually exclusive). > 3. If --zk-host is specified at all (with solr-home-dir or without), > --collection should be provided. > > Will rectify.
Also, I'm open to suggestions on the name of the action "search batch indexer" ;). - Abraham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22848/#review46810 ----------------------------------------------------------- On July 10, 2014, 11:58 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22848/ > ----------------------------------------------------------- > > (Updated July 10, 2014, 11:58 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1895 > https://issues.apache.org/jira/browse/OOZIE-1895 > > > Repository: oozie-git > > > Description > ------- > > - Provide 2 different paths of execution: Zookeeper config and solrconfig. > With solrconfig, --shards argument should be passed via "argument" in the > action xml. With the zookeeper config, --collection should be provided via > "argument" in the action xml. > - Go live mode not supported in secure clusters. > - Only available with Hadoop 2. > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java 33935d3 > client/src/main/resources/search-batch-indexer-action-0.1.xsd PRE-CREATION > core/pom.xml e152266 > > core/src/main/java/org/apache/oozie/action/hadoop/SearchBatchIndexerActionExecutor.java > PRE-CREATION > core/src/main/resources/oozie-default.xml b944d3d > docs/src/site/twiki/DG_SearchBatchIndexerActionExtension.twiki PRE-CREATION > docs/src/site/twiki/index.twiki f078bf5 > pom.xml bad1e0f > sharelib/pom.xml df20294 > sharelib/search/pom.xml PRE-CREATION > > sharelib/search/src/main/java/org/apache/oozie/action/hadoop/SearchBatchIndexerMain.java > PRE-CREATION > > sharelib/search/src/test/java/org/apache/oozie/action/hadoop/TestSearchBatchIndexerActionExecutor.java > PRE-CREATION > sharelib/search/src/test/resources/morphlines/basic.conf PRE-CREATION > sharelib/search/src/test/resources/solr/conf/elevate.xml PRE-CREATION > sharelib/search/src/test/resources/solr/conf/lang/contractions_ca.txt > PRE-CREATION > sharelib/search/src/test/resources/solr/conf/lang/contractions_fr.txt > PRE-CREATION > sharelib/search/src/test/resources/solr/conf/lang/contractions_ga.txt > PRE-CREATION > sharelib/search/src/test/resources/solr/conf/lang/contractions_it.txt > PRE-CREATION > sharelib/search/src/test/resources/solr/conf/lang/hyphenations_ga.txt > PRE-CREATION > sharelib/search/src/test/resources/solr/conf/lang/stemdict_nl.txt > PRE-CREATION > sharelib/search/src/test/resources/solr/conf/lang/stoptags_ja.txt > PRE-CREATION > sharelib/search/src/test/resources/solr/conf/lang/stopwords_en.txt > PRE-CREATION > sharelib/search/src/test/resources/solr/conf/lang/userdict_ja.txt > PRE-CREATION > sharelib/search/src/test/resources/solr/conf/protwords.txt PRE-CREATION > sharelib/search/src/test/resources/solr/conf/schema.xml PRE-CREATION > sharelib/search/src/test/resources/solr/conf/solrconfig.xml PRE-CREATION > sharelib/search/src/test/resources/solr/conf/stopwords.txt PRE-CREATION > sharelib/search/src/test/resources/solr/conf/synonyms.txt PRE-CREATION > src/main/assemblies/sharelib.xml 891d9dc > webapp/pom.xml 93cfcef > > Diff: https://reviews.apache.org/r/22848/diff/ > > > Testing > ------- > > Wrote a couple of tests and manually tested on Kerberized environment. > > > Thanks, > > Abraham Elmahrek > >
