> On July 16, 2014, 2:57 a.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/service/ZKLocksService.java, line 181 > > <https://reviews.apache.org/r/23403/diff/2/?file=628236#file628236line181> > > > > Can move val == 0 condition inside synchronized block and remove the > > TODO block.
That doesn't fix the issue. Count can be increase after we call lock.getParticipantNodes().size(); Count is increased after we acquire the lock. - Purshotam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23403/#review47851 ----------------------------------------------------------- On July 11, 2014, 12:56 a.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23403/ > ----------------------------------------------------------- > > (Updated July 11, 2014, 12:56 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1923 > https://issues.apache.org/jira/browse/OOZIE-1923 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-1923 ZKLocksService locks are not re-entrant like MemoryLocks > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/service/ZKLocksService.java d03a899 > core/src/test/java/org/apache/oozie/service/TestZKLocksService.java a773469 > > Diff: https://reviews.apache.org/r/23403/diff/ > > > Testing > ------- > > UTC > > > Thanks, > > Purshotam Shah > >
