[
https://issues.apache.org/jira/browse/OOZIE-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Purshotam Shah updated OOZIE-1937:
----------------------------------
Description:
Lot of places we do inappropriate logging or extra looping only to log
statement.
Let have this JIRA to capture them.
{code}
PriorityDelayQueue.antiStarvation()
StringBuilder sb = new StringBuilder();
for (int i = 0; i < queues.length; i++) {
sb.append("P[").append(i).append("]=").append(queues[i].size()).append(" ");
}
debug("sub-queue sizes: {0}", sb.toString());
{code}
{code}
LOG.trace("Stack trace while queueing event : {0}", event, new Throwable()); is
not needed.
EventHandlerService.queueEvent(Event event) {
LOG = LogUtils.setLogPrefix(LOG, event);
LOG.debug("Queueing event : {0}", event);
LOG.trace("Stack trace while queueing event : {0}", event, new
Throwable());
eventQueue.add(event);
LogUtils.clearLogPrefix();
}
{code}
was:
Lot of places we do inappropriate logging or extra looping only to log
statement.
Let have this JIRA to capture them.
{code}
PriorityDelayQueue.antiStarvation()
StringBuilder sb = new StringBuilder();
for (int i = 0; i < queues.length; i++) {
sb.append("P[").append(i).append("]=").append(queues[i].size()).append(" ");
}
debug("sub-queue sizes: {0}", sb.toString());
{code}
LOG.trace("Stack trace while queueing event : {0}", event, new Throwable()); is
not needed.
{code}
EventHandlerService.queueEvent(Event event) {
LOG = LogUtils.setLogPrefix(LOG, event);
LOG.debug("Queueing event : {0}", event);
LOG.trace("Stack trace while queueing event : {0}", event, new
Throwable());
eventQueue.add(event);
LogUtils.clearLogPrefix();
}
{code}
> Logging issues
> --------------
>
> Key: OOZIE-1937
> URL: https://issues.apache.org/jira/browse/OOZIE-1937
> Project: Oozie
> Issue Type: Bug
> Reporter: Purshotam Shah
>
> Lot of places we do inappropriate logging or extra looping only to log
> statement.
> Let have this JIRA to capture them.
> {code}
> PriorityDelayQueue.antiStarvation()
> StringBuilder sb = new StringBuilder();
> for (int i = 0; i < queues.length; i++) {
>
> sb.append("P[").append(i).append("]=").append(queues[i].size()).append(" ");
> }
> debug("sub-queue sizes: {0}", sb.toString());
> {code}
> {code}
> LOG.trace("Stack trace while queueing event : {0}", event, new Throwable());
> is not needed.
> EventHandlerService.queueEvent(Event event) {
> LOG = LogUtils.setLogPrefix(LOG, event);
> LOG.debug("Queueing event : {0}", event);
> LOG.trace("Stack trace while queueing event : {0}", event, new
> Throwable());
> eventQueue.add(event);
> LogUtils.clearLogPrefix();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
