[
https://issues.apache.org/jira/browse/OOZIE-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074117#comment-14074117
]
Mona Chitnis commented on OOZIE-1811:
-------------------------------------
I'd suggest getting rid of the static reference to JPAService in each of the
Query Executors. We can always get the reference to it from the Services
singleton, while executing the query. By keeping another static reference and
manipulating it through the constructor and destroy(), we run the risk of
nullifying it inadvertently. This is why suddenly so many tests are becoming
flaky and it is very tough to detect exact patterns or even fix tests in a
foolproof way.
I ran the whole suit with the static reference removed and only 2 tests failed
- which is quite an improvement!
{code}
Results :
Failed tests:
testBundleId(org.apache.oozie.servlet.TestBulkMonitorWebServiceAPI):
expected:<SUCCEEDED> but was:<RUNNING>
Tests in error:
testSucCoordPurgeXCommand(org.apache.oozie.command.TestPurgeXCommand): E0604:
Job does not exist [0000000-140724213655573-oozie-chit-C]
{code}
Test#2 here is failing with error StoreService cannot work without JPAService.
We can replace usage of StoreService completely as it is superceded by
JPAService anyway.
Test #1 doesnt really have any error except random assert fail, and this test
is not usually flaky so can ignore
> Current test failures in trunk
> ------------------------------
>
> Key: OOZIE-1811
> URL: https://issues.apache.org/jira/browse/OOZIE-1811
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk
> Reporter: Robert Kanter
> Assignee: Mona Chitnis
> Priority: Critical
>
> There's a bunch of test failures currently in trunk; I'm not sure what
> commit(s) is the cause, but I think it was somewhat recent.
> e.g. https://builds.apache.org/job/oozie-trunk-precommit-build/1199/
> Reproducible by running these tests, instead of having to run them all, which
> takes a lot longer :)
> {noformat}
> mvn clean test
> -Dtest=TestSubWorkflowActionExecutor,TestBunldeChangeXCommand,TestCoordUpdateXCommand,TestCoordJobQueryExecutor,TestStatusTransitService,TestSLAEventGeneration
> {noformat}
> {noformat}
> Results :
> Failed tests:
> testCoordinatorActionCommandsSubmitAndStart(org.apache.oozie.sla.TestSLAEventGeneration):
> expected:<...11921-oozie-rkan-C@1[]> but was:<...11921-oozie-rkan-C@1[2]>
>
> testCoordStatusTransitServiceDoneWithError(org.apache.oozie.service.TestStatusTransitService):
> expected:<DONEWITHERROR> but was:<KILLED>
>
> testBundleStatusTransitRunningFromKilled(org.apache.oozie.service.TestStatusTransitService):
> expected:<RUNNING> but was:<KILLED>
> Tests in error:
> testGetList(org.apache.oozie.executor.jpa.TestCoordJobQueryExecutor)
> testInsert(org.apache.oozie.executor.jpa.TestCoordJobQueryExecutor)
> Tests run: 62, Failures: 3, Errors: 2, Skipped: 0
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
