[
https://issues.apache.org/jira/browse/OOZIE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Azrael updated OOZIE-1939:
--------------------------
Attachment: OOZIE-1939.3.patch
Thanks for answer and I am afraid I am making noise.
Updated the patch and upload to reviewboard.
The main issue is the where should be reset XLog.Info.
As the comment, ThreadPoolExecutor override beforeExecute() method to reset the
log info.
The CompositeCallable contains different log info and the syncAction execution
cause the change of log info. So, the context depends on XCommand(jobId,
actionId) should be reset. Hence, IMO, this overriding might be duplicated code
and be removed.
Review this, please.
> Incorrect job information is set while logging
> ----------------------------------------------
>
> Key: OOZIE-1939
> URL: https://issues.apache.org/jira/browse/OOZIE-1939
> Project: Oozie
> Issue Type: Bug
> Reporter: Purshotam Shah
> Assignee: Azrael
> Attachments: OOZIE-1939.1.patch, OOZIE-1939.2.patch,
> OOZIE-1939.3.patch
>
>
> {code}
> 2014-07-16 17:28:06,422 DEBUG CoordChangeXCommand:545 [http-0.0.0.0-4443-5] -
> USER[hadoopqa] GROUP[users] TOKEN[] APP[coordB236]
> JOB[0011514-140716042555-oozie-oozi-C] ACTION[-] Acquired lock for
> [0011385-140716042555-oozie-oozi-C] in [coord_change]
> 2014-07-16 17:28:06,422 TRACE CoordChangeXCommand:548 [http-0.0.0.0-4443-5] -
> USER[hadoopqa] GROUP[users] TOKEN[] APP[coordB236]
> JOB[0011514-140716042555-oozie-oozi-C] ACTION[-] Load state for
> [0011385-140716042555-oozie-oozi-C]
> {code}
> {code}
> protected void loadState() throws CommandException {
> jpaService = Services.get().get(JPAService.class);
> if (jpaService == null) {
> LOG.error(ErrorCode.E0610);
> }
> try {
> coordJob =
> CoordJobQueryExecutor.getInstance().get(CoordJobQuery.GET_COORD_JOB_MATERIALIZE,
> jobId);
> prevStatus = coordJob.getStatus();
> }
> catch (JPAExecutorException jex) {
> throw new CommandException(jex);
> }
> // calculate start materialize and end materialize time
> calcMatdTime();
> LogUtils.setLogInfo(coordJob, logInfo);
> }
> {code}
> Most of the commands set jobinfo after loadstate, because of that few log
> statements ( like acquiring lock, load state) logs with previous jobinfo.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
