----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24187/#review49628 -----------------------------------------------------------
+1 pending minor comment about naming and checking via e-2-e test core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/24187/#comment86870> keep naming consistent i.e. launcherEnvMap and launcherEnvMapStr core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/24187/#comment86865> false formatting change.. but its ok to include core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/24187/#comment86866> same as above - Mona Chitnis On Aug. 1, 2014, 5:56 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24187/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2014, 5:56 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1958 > https://issues.apache.org/jira/browse/OOZIE-1958 > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1958?filter=-1 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 94b55cf > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 72a137c > > Diff: https://reviews.apache.org/r/24187/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
