[ 
https://issues.apache.org/jira/browse/OOZIE-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100289#comment-14100289
 ] 

Shwetha G S commented on OOZIE-1973:
------------------------------------

[~puru], the stacktrace is not because of updateLauncherLib(Yes, even this 
needs to be fixed). Its in this code:
{code}
    public List<Path> getSystemLibJars(String actionKey) throws IOException {
        List<Path> returnList = new ArrayList<Path>();
        // Sharelib map is empty means that on previous or startup attempt of
        // caching launcher jars has failed.Trying to reload
        if (isShipLauncherEnabled) {
            if (launcherLibMap.isEmpty()) {
                synchronized (ShareLibService.class) {
                    if (launcherLibMap.isEmpty()) {
                        updateLauncherLib();
                    }
                }
            }
            returnList = launcherLibMap.get(actionKey);
        }
        if (actionKey.equals(JavaActionExecutor.OOZIE_COMMON_LIBDIR)) {
            List<Path> sharelibList = getShareLibJars(actionKey);
            if (sharelibList != null) {
                returnList.addAll(sharelibList);
            }
        }
        return returnList;
    }
{code}
If ship launcher jars is enabled,  returnList = launcherLibMap.get(actionKey). 
After this, common oozie sharelib jars are added to the same returnList by all 
threads.

[~rkanter], it will be good if we can fix this for 4.1 release. ship launcher 
jars doesn't work

> ConcurrentModificationException in Sharelib service
> ---------------------------------------------------
>
>                 Key: OOZIE-1973
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1973
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Shwetha G S
>             Fix For: 4.1.0
>
>
> {quote}
> 2014-08-14 07:45:37,227  WARN pool-2-thread-57 ActionStartXCommand - SERVER[] 
> USER[] GROUP[-] TOKEN[] APP[] JOB[0000850-140814062742075-oozie-oozi-W] 
> ACTION[0000850-140814062742075-oozie-oozi-W@action] Error starting
>  action [enhance]. ErrorType [ERROR], ErrorCode 
> [ConcurrentModificationException], Message [ConcurrentModificationException: 
> null]
> org.apache.oozie.action.ActionExecutorException: 
> ConcurrentModificationException: null
>         at 
> org.apache.oozie.action.ActionExecutor.convertException(ActionExecutor.java:401)
>         at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.submitLauncher(JavaActionExecutor.java:930)
>         at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.start(JavaActionExecutor.java:1085)
>         at 
> org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:228)
>         at 
> org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:63)
>         at org.apache.oozie.command.XCommand.call(XCommand.java:283)
>         at 
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:323)
>         at 
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:252)
>         at 
> org.apache.oozie.service.CallableQueueService$CallableWrapper.run(CallableQueueService.java:174)
>         at 
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
>         at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
>         at java.lang.Thread.run(Thread.java:662)
> Caused by: java.util.ConcurrentModificationException
>         at 
> java.util.AbstractList$Itr.checkForComodification(AbstractList.java:372)
>         at java.util.AbstractList$Itr.next(AbstractList.java:343)
>         at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.addSystemShareLibForAction(JavaActionExecutor.java:559)
>         at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.addAllShareLibs(JavaActionExecutor.java:650)
>         at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.setLibFilesArchives(JavaActionExecutor.java:641)
>         at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.submitLauncher(JavaActionExecutor.java:835)
> {quote}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to