[ 
https://issues.apache.org/jira/browse/OOZIE-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101927#comment-14101927
 ] 

Shwetha G S commented on OOZIE-1705:
------------------------------------

{quote}
Will adding the gc log cause a lot of overhead or anything like that?
{quote}
In almost all java applications, gc logging is turned on by default. The 
overhead is very small

{quote}
Looks like it's going to default to ${OOZIE_HOME}/logs/gc.log. Is it possible 
to put it under ${oozie.log.dir} so it will always be next to the other logs? 
Not everyone has the logs dir under ${OOZIE_HOME}.
{quote}
Will do

{quote}
For the log4j pattern change, won't most threads be from the thread pool and 
not have a useful name? Perhaps we should add names for each thread we create 
in the code?
{quote}
they will have thread id like thread-<number>

{quote}
For the log4j pattern change, I don't think we should remove the %c{1}:%L; this 
is really useful because it tells us which class and line number it came from.
{quote}
When you have code that logs directly, yes line number and class name are 
useful. But for oozie, all logging is done using XLog and the class name and 
line numbers in oozie.log always point to XLog code. (Its bad, we should fix it)

> Enable gc logs and print thread id in logs
> ------------------------------------------
>
>                 Key: OOZIE-1705
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1705
>             Project: Oozie
>          Issue Type: Task
>            Reporter: Shwetha G S
>            Assignee: Shwetha G S
>            Priority: Minor
>             Fix For: trunk
>
>         Attachments: OOZIE-1705.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to