[ https://issues.apache.org/jira/browse/OOZIE-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110203#comment-14110203 ]
Hadoop QA commented on OOZIE-1923: ---------------------------------- Testing JIRA OOZIE-1923 Cleaning local git workspace ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:green}+1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:green}+1{color} the patch does not introduce any line longer than 132 . {color:green}+1{color} the patch does adds/modifies 1 testcase(s) {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1 BACKWARDS_COMPATIBILITY{color} . {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . {color:green}+1{color} the patch does not modify JPA files {color:red}-1 TESTS{color} . Tests run: 1511 . Tests failed: 6 . Tests errors: 2 . The patch failed the following testcases: . testMain(org.apache.oozie.action.hadoop.TestHiveMain) . testPigScript(org.apache.oozie.action.hadoop.TestPigMainWithOldAPI) . testPigScript(org.apache.oozie.action.hadoop.TestPigMain) . testEmbeddedPigWithinPython(org.apache.oozie.action.hadoop.TestPigMain) . testPig_withNullExternalID(org.apache.oozie.action.hadoop.TestPigMain) . testCoordMaterializeTriggerService3(org.apache.oozie.service.TestCoordMaterializeTriggerService) {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/1712/ > ZKLocksService locks are not re-entrant like MemoryLocks > -------------------------------------------------------- > > Key: OOZIE-1923 > URL: https://issues.apache.org/jira/browse/OOZIE-1923 > Project: Oozie > Issue Type: Bug > Components: HA > Reporter: Purshotam Shah > Assignee: Purshotam Shah > Fix For: 4.1.0 > > Attachments: OOZIE-1923-V1.patch, OOZIE-1923-V2.patch > > > This is because we are creating InterProcessReadWriteLock instance for every > path. > We should store InterProcessReadWriteLock and reuse for same path like > MemoryLocksService. > We should also add tests for both ZKLocksService and MemoryLocksService to > verify. -- This message was sent by Atlassian JIRA (v6.2#6252)