----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25279/ -----------------------------------------------------------
Review request for oozie. Repository: oozie-git Description ------- The admin servlet has a call that returns a list of available timezones. On startup, it prepares a list of GMT offsets (e.g. "GMT-12:00", "GMT-11:00", etc), which is only generated once. But the rest of the timezones (e.g. "America/Los_Angeles", etc) are processed from TimeZone every time the admin servlet is asked for the list. We should refactor this to generate/process the entire list either the first time its called or at startup and then simply return the JSONArray when the admin servlet is asked for the list. Diffs ----- core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java 0e44bdf Diff: https://reviews.apache.org/r/25279/diff/ Testing ------- Since this is minor refactoring of code, it does not require a testcase. There is already one Testv1AdminServlet which tests this functionality. Thanks, Sreepathi Prasanna
