[ 
https://issues.apache.org/jira/browse/OOZIE-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shwetha G S updated OOZIE-1977:
-------------------------------
    Attachment: OOZIE-1977-v2.patch

Here is the output of raw patch analysis:
{noformat}
----------------------------

+1 PATCH_APPLIES
-1 RAW_PATCH_ANALYSIS
    -1 the patch seems to contain 1 line(s) with @author tags
       + authorTagsDetails=`grep "^+" ${PATCHFILE} | grep -v "^+++" | grep -i 
-e ".*\*.* @author"`
    +1 the patch does not introduce any tabs
    +1 the patch does not introduce any trailing spaces
    -1 the patch contains        1 line(s) longer than 132 characters
       +  longLinesDetails=`grep "^+" ${PATCHFILE} | grep -v "^+++" | awk 
'BEGIN{lines=""}{if ( length > 133 ) { lines=lines $0 "\n"} }END{ print lines}'`
    +1 the patch does adds/modifies 1 testcase(s)

----------------------------
{noformat}
We can leave the longer line as is I guess since its in script. @author is not 
an issue

> Display patch analysis issues
> -----------------------------
>
>                 Key: OOZIE-1977
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1977
>             Project: Oozie
>          Issue Type: Sub-task
>            Reporter: Shwetha G S
>            Assignee: Shwetha G S
>             Fix For: trunk
>
>         Attachments: OOZIE-1977-v2.patch, OOZIE-1977.patch
>
>
> Currently, RAW_PATCH_ANALYSIS displays this
> {noformat}
> -1 RAW_PATCH_ANALYSIS
>     +1 the patch does not introduce any @author tags
>     +1 the patch does not introduce any tabs
>     -1 the patch contains 1 line(s) with trailing spaces
>     +1 the patch does not introduce any line longer than 132
>     +1 the patch does adds/modifies 3 testcase(s)
> {noformat}
> Its painful to figure out the lines causing the issue



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to