> On Sept. 10, 2014, 6:32 a.m., shwethags wrote: > > core/pom.xml, line 368 > > <https://reviews.apache.org/r/25041/diff/4/?file=684213#file684213line368> > > > > even hbase credential requires hbase jar which is not included in oozie > > war. It depends on config, right? If credential is enabled in config, users > > can add the jar manually as well?
I suppose that's true. I'll make it "provided" when committing. On Sept. 10, 2014, 6:32 a.m., Robert Kanter wrote: > > Minor comment about including hive-jdbc. Looks good otherwise. If you have > > tested end to end flow, good to go Yup, tested end-to-end, with and without security too. We've also been shipping something very similar in CDH for a while too. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25041/#review52828 ----------------------------------------------------------- On Sept. 9, 2014, 11:56 p.m., Robert Kanter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25041/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 11:56 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1457 > https://issues.apache.org/jira/browse/OOZIE-1457 > > > Repository: oozie-git > > > Description > ------- > > See https://issues.apache.org/jira/browse/OOZIE-1457 > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java 79a9b68 > client/src/main/resources/hive2-action-0.1.xsd PRE-CREATION > core/pom.xml 59b6ecd > core/src/main/conf/oozie-site.xml 32f87f5 > core/src/main/java/org/apache/oozie/action/hadoop/Hive2ActionExecutor.java > PRE-CREATION > core/src/main/java/org/apache/oozie/action/hadoop/Hive2Credentials.java > PRE-CREATION > core/src/test/java/org/apache/oozie/test/XTestCase.java 0dd7d71 > core/src/test/java/org/apache/oozie/test/hive/AbstractHiveService.java > PRE-CREATION > core/src/test/java/org/apache/oozie/test/hive/MiniHS2.java PRE-CREATION > docs/src/site/twiki/DG_Hive2ActionExtension.twiki PRE-CREATION > docs/src/site/twiki/DG_UnifiedCredentialsModule.twiki 7c52970 > docs/src/site/twiki/index.twiki f078bf5 > pom.xml 0b19431 > sharelib/hive2/pom.xml PRE-CREATION > sharelib/hive2/src/main/java/org/apache/oozie/action/hadoop/Hive2Main.java > PRE-CREATION > > sharelib/hive2/src/test/java/org/apache/oozie/action/hadoop/TestHive2ActionExecutor.java > PRE-CREATION > sharelib/pom.xml 1d6e4bd > src/main/assemblies/sharelib.xml 891d9dc > webapp/pom.xml ec6d836 > > Diff: https://reviews.apache.org/r/25041/diff/ > > > Testing > ------- > > TestHiveServer2ActionExecutor will fail against Hadoop 1 until we update to > Hadoop 1.2.1; though I've tested it and it should pass once we do. I've also > tested the action in an actual cluster. > > > Thanks, > > Robert Kanter > >
