> On Sept. 12, 2014, 11:18 a.m., shwethags wrote:
> > docs/src/site/twiki/WorkflowFunctionalSpec.twiki, line 634
> > <https://reviews.apache.org/r/24165/diff/1/?file=647181#file647181line634>
> >
> > Will the JobConf have all the workflow params? Else, it may not be
> > useful. For example, setting input path and output path depends on workflow
> > params
>
> Robert Kanter wrote:
> You mean the stuff that gets set in job.properties? I'll look if there's
> a good way to include them.
I don't think there's a good way to do this. The OozieActionConfigurator gets
called from the launcher job, which doesn't have access to the parameters. I
think it should be okay not to include these directly because
(a) the actionConf will contain resolved values already (i.e. if the user set
"mapred.input.path" to "/user/${user.name}/foo" in the action's <configuration>
section, that would already be resolved to "/user/rkanter/foo" in the
OozieActionConfigurator
(b) if the user really wants to propagate a value to be used in this code, they
can simply set it in the action's <configuration> section and read it from the
actionConf
Makes sense?
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24165/#review53165
-----------------------------------------------------------
On July 31, 2014, 10:33 p.m., Robert Kanter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24165/
> -----------------------------------------------------------
>
> (Updated July 31, 2014, 10:33 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1954
> https://issues.apache.org/jira/browse/OOZIE-1954
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> See https://issues.apache.org/jira/browse/OOZIE-1954
>
>
> Diffs
> -----
>
> client/src/main/resources/oozie-workflow-0.5.xsd 6620a4e
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
> 94b55cf
> core/src/test/java/org/apache/oozie/action/hadoop/MapperReducerForTest.java
> 7fe1f42
> docs/src/site/twiki/WorkflowFunctionalSpec.twiki 3319bcc
> examples/src/main/apps/map-reduce/job-with-config-class.properties
> PRE-CREATION
> examples/src/main/apps/map-reduce/job.properties 7b7a24c
> examples/src/main/apps/map-reduce/workflow-with-config-class.xml
> PRE-CREATION
>
> examples/src/main/java/org/apache/oozie/example/SampleOozieActionConfigurator.java
> PRE-CREATION
>
> sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java
> 2cb690f
>
> sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java
> 322f498
>
> sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/MapReduceMain.java
> f417a78
>
> sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/OozieActionConfigurator.java
> PRE-CREATION
>
> sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/OozieActionConfiguratorException.java
> PRE-CREATION
> sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PipesMain.java
> 67a2a43
>
> sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/OozieActionConfiguratorForTest.java
> PRE-CREATION
>
> sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java
> e78c98a
>
> sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutorUberJar.java
> bcc22f2
>
> Diff: https://reviews.apache.org/r/24165/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Robert Kanter
>
>
