[
https://issues.apache.org/jira/browse/OOZIE-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175403#comment-14175403
]
Robert Kanter commented on OOZIE-1890:
--------------------------------------
Overall the patch looks good to me.
One thing though: I saw a some methods that had originally taken an
Configuration object and then used it for reading configs. In some places they
get replaced with {{ConfigurationService.OozieConfigs.getInt(conf,
PROPERTY_NAME);}} but in others it's only
{{ConfigurationService.OozieConfigs.getInt(PROPERTY_NAME);}} and the passed in
Configuration is not used. Shouldn't they all be the former? (A good example
of this is in EventHandlerService.initWorkerThreads where we see both
variations).
Also, this is a big change, so it would be good to get multiple reviews.
[~egashira], would you be able to also review?
> Make oozie-site empty and reconcile defaults between oozie-default and the
> code
> -------------------------------------------------------------------------------
>
> Key: OOZIE-1890
> URL: https://issues.apache.org/jira/browse/OOZIE-1890
> Project: Oozie
> Issue Type: Bug
> Components: core
> Reporter: Robert Kanter
> Assignee: Azrael
> Attachments: OOZIE-1890.1.patch, OOZIE-1890.2.patch,
> OOZIE-1890.3.patch
>
>
> As shwetha and puru suggested in OOZIE-1888, oozie-site vs oozie-default is a
> point of confusion for users. We've also had issues in the past where
> they've had different values from each other and/or from the code's default
> (i.e. {{conf.get(PROP_NAME, DEFAULT_VALUE)}}).
> We should make oozie-default the only source of truth by:
> # Putting all configuration properties in oozie-default.
> # Making oozie-site empty; if the user wants to change a property, they can
> copy it out of the for-reference oozie-default.
> # Getting rid of the code defaults. It's easy for these to be out of sync
> with oozie-default, leading to confusion. They aren't used anyway because
> oozie-default should always be there (and will now have every property)
> This will require looking through all classes to make sure we're not missing
> anything from oozie-default and also checking that we put the proper default
> value (from all 3 sources) into oozie-default. It may be nice to also
> reorder the properties in oozie-default alphabetically (and also do this
> going forward with new properties).
> Also, {{oozie.service.WorkflowAppService.system.libpath}} should be set to
> "/user/$\{user.name\}/share/lib" (which is what OOZIE-1888 wanted to do).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
