> On Oct. 17, 2014, 7:38 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/coord/CoordUtils.java, lines 146-147 > > <https://reviews.apache.org/r/24487/diff/4/?file=692718#file692718line146> > > > > What happens to other commands?
other commands calling this util method - kill and rerun. in both cases, we should allow superset of action and ability to skip over if all actions in the range are not there. > On Oct. 17, 2014, 7:38 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/coord/CoordUtils.java, line 258 > > <https://reviews.apache.org/r/24487/diff/4/?file=692718#file692718line258> > > > > private referenced in another class too - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24487/#review57158 ----------------------------------------------------------- On Sept. 17, 2014, 6:59 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24487/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2014, 6:59 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1913 > https://issues.apache.org/jira/browse/OOZIE-1913 > > > Repository: oozie-git > > > Description > ------- > > See Jira > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java f3ffd1f > client/src/main/java/org/apache/oozie/client/OozieClient.java d6ff2d0 > > client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java > 801ad7e > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 4b393c8 > core/src/main/java/org/apache/oozie/CoordinatorActionBean.java cc5596b > core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 71a9ab4 > core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java > 070cee5 > > core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java > de78ab7 > > core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 05b7a62 > core/src/main/java/org/apache/oozie/coord/CoordUtils.java 4643d73 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java > 0aee0e4 > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java > 2c9e00e > core/src/main/java/org/apache/oozie/jms/JMSSLAEventListener.java c19839f > > core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java > ee1085a > core/src/main/java/org/apache/oozie/service/EventHandlerService.java > 244c048 > core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 11835ed > core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 2578e41 > core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java eb699e6 > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 396661a > core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java de4f865 > core/src/main/java/org/apache/oozie/sla/BundleDisableSlaAlertsXCommand.java > PRE-CREATION > core/src/main/java/org/apache/oozie/sla/BundleEnableSlaAlertsXCommand.java > PRE-CREATION > core/src/main/java/org/apache/oozie/sla/CoordDisableSlaAlertsXCommand.java > PRE-CREATION > core/src/main/java/org/apache/oozie/sla/CoordEnableSlaAlertsXCommand.java > PRE-CREATION > core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 189d5ea > core/src/main/java/org/apache/oozie/sla/SLACalculator.java 20f93b5 > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java cdf8b73 > core/src/main/java/org/apache/oozie/sla/SLAOperations.java f5fc826 > core/src/main/java/org/apache/oozie/sla/service/SLAService.java 89615bc > core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java > 7c2620c > core/src/main/resources/oozie-default.xml 6a91dc6 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java > f13e48f > core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java ae3f18d > core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java > 30fd151 > core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 48193c7 > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java db9c594 > core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > db3f6eb > > Diff: https://reviews.apache.org/r/24487/diff/ > > > Testing > ------- > > unit tests added, e-2-e test with CLI command done > > > Thanks, > > Mona Chitnis > >
