> On Oct. 29, 2014, 10:11 a.m., Ryota Egashira wrote: > > core/src/main/java/org/apache/oozie/event/listener/ZKConnectionListener.java, > > line 61 > > <https://reviews.apache.org/r/23225/diff/4/?file=725615#file725615line61> > > > > i don't find oozie.zookeeper.server.shutdown.ontimeout set in > > oozie-default.xml, can you double-check?
I checked it, oozie.zookeeper.server.shutdown.ontimeout is in oozie-default.xml. For the pre-commit build, I rebased on the latest branch but on review board, it doesn't show in changes. assertEquals(true, ConfigurationService.getBoolean(ZKConnectionListener.CONF_SHUTDOWN_ON_TIMEOUT)) : passed. > On Oct. 29, 2014, 10:11 a.m., Ryota Egashira wrote: > > core/src/main/java/org/apache/oozie/service/ConfigurationService.java, line > > 443 > > <https://reviews.apache.org/r/23225/diff/4/?file=725624#file725624line443> > > > > i might be missing something but, does the value of this map really > > need to be OozieConfig? since key of map = OozieConfig.name anyway and > > look redundant. isn't it enough to put string as value instead of > > OozieConfig? Yes, You are right. I changed to Map<String,String>. And I removed OozieConfigs as getXXX(conf, PROPERTY_NAME) method has passed in Configuration. I replaced with ConfigurationService.getInt(conf, PROPERTY_NAME) > On Oct. 29, 2014, 10:11 a.m., Ryota Egashira wrote: > > core/src/main/java/org/apache/oozie/service/PurgeService.java, line 95 > > <https://reviews.apache.org/r/23225/diff/4/?file=725638#file725638line95> > > > > trailing space Thanks, it is hard to find it. - Azrael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23225/#review58968 ----------------------------------------------------------- On Oct. 20, 2014, 8:50 a.m., Azrael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23225/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 8:50 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1890 > https://issues.apache.org/jira/browse/OOZIE-1890 > > > Repository: oozie-git > > > Description > ------- > > I added ConfigurationService.OozieConfigs to contains all the configuration > from oozie-default and oozie-site. > OozieConfigs.OozieConfig consist of name and value, So no need code default. > > > long warnThresholdMs = > ConfigurationService.OozieConfigs.getLong(WARN_THRESHOLD_KEY); > > > Diffs > ----- > > core/src/main/conf/oozie-site.xml c028ca2 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 8591d63 > core/src/main/java/org/apache/oozie/DagEngine.java bea312f > core/src/main/java/org/apache/oozie/action/ActionExecutor.java 2053f32 > core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProvider.java > 9c66e58 > core/src/main/java/org/apache/oozie/action/hadoop/DistcpActionExecutor.java > 4d2f7b2 > core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java > 6a7f817 > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 201cfa3 > > core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > 5cba732 > core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java e8733a1 > > core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java > b8c7e57 > core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java > 734fce9 > core/src/main/java/org/apache/oozie/command/XCommand.java 7f850cb > > core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > b26c1e2 > > core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java > d220434 > > core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 05b7a62 > > core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 68597b0 > core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > aec7199 > core/src/main/java/org/apache/oozie/command/wf/JobXCommand.java 747d935 > core/src/main/java/org/apache/oozie/command/wf/NotificationXCommand.java > 73ce9a7 > core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java 205dbb6 > > core/src/main/java/org/apache/oozie/event/listener/ZKConnectionListener.java > a5d22c0 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInfoJPAExecutor.java > 319a49b > core/src/main/java/org/apache/oozie/jms/JMSJobEventListener.java a458165 > > core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java > b082567 > core/src/main/java/org/apache/oozie/service/ActionCheckerService.java > b085014 > core/src/main/java/org/apache/oozie/service/ActionService.java ebfe299 > core/src/main/java/org/apache/oozie/service/AuthorizationService.java > 293de3f > core/src/main/java/org/apache/oozie/service/CallableQueueService.java > 25fed7d > core/src/main/java/org/apache/oozie/service/CallbackService.java e7463cf > core/src/main/java/org/apache/oozie/service/ConfigurationService.java > 5e47081 > > core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java > ee1085a > core/src/main/java/org/apache/oozie/service/DBLiteWorkflowStoreService.java > df83873 > core/src/main/java/org/apache/oozie/service/ELService.java 8406955 > core/src/main/java/org/apache/oozie/service/EventHandlerService.java > 244c048 > core/src/main/java/org/apache/oozie/service/HCatAccessorService.java > a645898 > core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java > db14d11 > core/src/main/java/org/apache/oozie/service/InstrumentationService.java > 093754e > core/src/main/java/org/apache/oozie/service/JMSAccessorService.java a79ca7e > core/src/main/java/org/apache/oozie/service/JMSTopicService.java e5cf1fe > core/src/main/java/org/apache/oozie/service/JPAService.java 8b9d1f5 > core/src/main/java/org/apache/oozie/service/JvmPauseMonitorService.java > 8bf9d1c > core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java > 8a7017e > core/src/main/java/org/apache/oozie/service/PauseTransitService.java > dda5404 > core/src/main/java/org/apache/oozie/service/PurgeService.java c370809 > core/src/main/java/org/apache/oozie/service/RecoveryService.java c47024d > core/src/main/java/org/apache/oozie/service/SchedulerService.java 7c7c0ff > core/src/main/java/org/apache/oozie/service/SchemaService.java a696a97 > core/src/main/java/org/apache/oozie/service/Service.java b7863ae > core/src/main/java/org/apache/oozie/service/Services.java eeba34f > core/src/main/java/org/apache/oozie/service/ShareLibService.java 63c5a41 > core/src/main/java/org/apache/oozie/service/StatusTransitService.java > 77dcda9 > core/src/main/java/org/apache/oozie/service/URIHandlerService.java c0144b4 > core/src/main/java/org/apache/oozie/service/UUIDService.java 4d209b5 > core/src/main/java/org/apache/oozie/service/WorkflowAppService.java d07f374 > core/src/main/java/org/apache/oozie/service/XLogStreamingService.java > 721e76b > core/src/main/java/org/apache/oozie/service/ZKLocksService.java 6f333c8 > core/src/main/java/org/apache/oozie/servlet/AuthFilter.java 054f484 > core/src/main/java/org/apache/oozie/servlet/CallbackServlet.java e488069 > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 8dc9608 > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 188144e > core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java > 8664a36 > core/src/main/java/org/apache/oozie/sla/service/SLAService.java 89615bc > core/src/main/java/org/apache/oozie/util/ConfigUtils.java b08ab64 > core/src/main/java/org/apache/oozie/util/DateUtils.java 9587625 > core/src/main/java/org/apache/oozie/util/StatusUtils.java 93b6193 > core/src/main/java/org/apache/oozie/util/XLogFilter.java 0a350db > core/src/main/java/org/apache/oozie/util/ZKUtils.java f535f86 > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java > cfa8697 > core/src/main/resources/oozie-default.xml 26eb7e0 > > core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java > aa9db5e > > core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java > d6ac554 > > core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java > dcc440a > > core/src/test/java/org/apache/oozie/command/coord/TestCoordActionNotificationXCommand.java > 7742dd4 > > core/src/test/java/org/apache/oozie/command/wf/TestNotificationXCommand.java > b260747 > core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java > 239fc86 > core/src/test/java/org/apache/oozie/service/TestConfigurationService.java > 2c008fd > core/src/test/java/org/apache/oozie/service/TestJobsConcurrencyService.java > 503d0c9 > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > b755353 > core/src/test/resources/wf-unsupported-action.xml 7a796cb > > sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java > 87c97d8 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 4923fe3 > > sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java > 8686a23 > > Diff: https://reviews.apache.org/r/23225/diff/ > > > Testing > ------- > > Unit test done. > Manual test done. > > > Thanks, > > Azrael Park > >
