[
https://issues.apache.org/jira/browse/OOZIE-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197023#comment-14197023
]
Robert Kanter commented on OOZIE-2051:
--------------------------------------
I took a look; here's my comments:
# Instead of {{XLog.getLog(...)}}, you can just use {{LOG}} which is already
defined as that
# For the action.xml files, we look for them once on startup; can we do that
with the action directories? Otherwise, it has to go through the whole action
directories thing every time an action is started
# The way this is now, properties specified in the the xml files in the action
directory has priority over the action.xml. I'm not sure if it should be that
way or the other way. Intuitively, I'd say the file should have priority
because it's more specific.
# Also, it's not providing any guarantee on the priority of properties within
the action directory. For example, if pig/a.xml and pig/b.xml both have a
property named "foo" with different values, it's not going to be necessarily
consistent with which has priority. I think that's going to cause problems for
the user. Unless you have a better idea, I think sorting the files
alphabetically (or reverse alphabetically) before loading them would be the
easiest. Make sure to mention the priority in the docs too.
# Can you update the existing test, or add a new test, that verifies that it
works with multiple files? And the priority is correct between the action.xml
file, and the multiple files in the action directory?
# Can you add documentation on this feature? And improve/add documentation on
the original feature?
> Allows multiple default action configuration files per action
> -------------------------------------------------------------
>
> Key: OOZIE-2051
> URL: https://issues.apache.org/jira/browse/OOZIE-2051
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 4.1.0
> Reporter: Venkat Ranganathan
> Assignee: Venkat Ranganathan
> Attachments: OOZIE-2051-2.patch, OOZIE-2051.patch
>
>
> Today, in oozie, we have a action-conf directory with one configuration file
> per action to provide default values. It is desirable to have a per action
> config directory where multiple configuration files can be either copied (or
> symlinked).
> This is useful for example, when we have an hive action with Tez engine (or
> Pig with tez engine) or other similar scenarios.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
