> On Nov. 3, 2014, 8:20 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/service/ShareLibService.java, line 604 > > <https://reviews.apache.org/r/27118/diff/2/?file=745099#file745099line604> > > > > Can remove else block and just add "Loading sharelib for " + key > > message to if block. Else there will be lot of log spam when symlinks are > > updated > > Purshotam Shah wrote: > Incase of symlink, else will never execute because key will always prefix > with oozie.
This is still an issue. Please remove in the final patch - Rohini ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27118/#review59617 ----------------------------------------------------------- On Nov. 6, 2014, 12:40 a.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27118/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 12:40 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2045 > https://issues.apache.org/jira/browse/OOZIE-2045 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2045 Symlink support for sharelib > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 201cfa3 > core/src/main/java/org/apache/oozie/service/ShareLibService.java 63c5a41 > core/src/main/resources/oozie-default.xml 26eb7e0 > core/src/test/java/org/apache/oozie/service/TestShareLibService.java > 68cb357 > > hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > e69de29 > > hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > e69de29 > > hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > e69de29 > > hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > e69de29 > > Diff: https://reviews.apache.org/r/27118/diff/ > > > Testing > ------- > > UTC and manul testing > > > Thanks, > > Purshotam Shah > >
