> On Nov. 26, 2014, 11:12 p.m., Robert Kanter wrote: > > This is really good. I think this will help make the build more flexible. > > And I know working on it was probably not the most fun thing to do :) > > > > I took a quick look through the patch. > > In addition to my two comments on the patch, I have one other concern: the > > patch changes a lot of the sharelib pom files. We need to make sure that > > either the sharelibs each contain the exact set of jars they did before or > > that any changes in jars do not break any actions. The former is probably > > easier because you don't have to do lots of testing beyond making sure the > > jars are there. Can you look into this? > > Robert Kanter wrote: > One other thing; I don't have time right now to try this out, but I'll > try to do it next week.
Ok. Will check the sharelib > On Nov. 26, 2014, 11:12 p.m., Robert Kanter wrote: > > pom.xml, line 94 > > <https://reviews.apache.org/r/22615/diff/7/?file=776596#file776596line94> > > > > There is no hadoop-auth for Hadoop 1.x; IIRC, we currently bundle > > hadoop-auth from 2.0.2-alpha when compiling against Hadoop 1.x. Have you > > tried compiling against Hadoop 1? > > > > If there isn't a way to reconcile this, we may have to hold your patch > > back until we drop Hadoop 1 support (at least in trunk), which there has > > been talk of before. hadoop-1 uses hadoop-core for auth. See hadoop-auth-1/pom.xml > On Nov. 26, 2014, 11:12 p.m., Robert Kanter wrote: > > tools/src/main/bin/ooziedb.sh, lines 44-52 > > <https://reviews.apache.org/r/22615/diff/7/?file=776614#file776614line44> > > > > I think the 'oozie-setup.sh sharelib' command will need something like > > this too, right? I think so. Will fix it - shwethags ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22615/#review63153 ----------------------------------------------------------- On Nov. 26, 2014, 6:45 a.m., shwethags wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22615/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2014, 6:45 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1876 > https://issues.apache.org/jira/browse/OOZIE-1876 > > > Repository: oozie-git > > > Description > ------- > > 1. hbase/hcatalog versions configurable > 2. Include hcatalog libs in final distro > > > Diffs > ----- > > client/pom.xml 365276d > client/src/main/bin/oozie 44943fa > core/pom.xml ca40e2e > distro/src/main/bin/oozied.sh 8eafc96 > docs/src/site/twiki/DG_QuickStart.twiki 526fbc3 > docs/src/site/twiki/ENG_Building.twiki 8d74b72 > examples/pom.xml 852d222 > hadooplibs/hadoop-0.23/pom.xml 6297dbd > hadooplibs/hadoop-1/pom.xml f0a32a5 > hadooplibs/hadoop-2/pom.xml 32d4b6c > hadooplibs/hadoop-3/pom.xml 4fd8f29 > hadooplibs/hadoop-auth-0.23/pom.xml 59cc7f1 > hadooplibs/hadoop-auth-1/pom.xml 7da7639 > hadooplibs/hadoop-auth-2/pom.xml cbdb523 > hadooplibs/hadoop-distcp-0.23/pom.xml 6e42986 > hadooplibs/hadoop-distcp-1/pom.xml 01eb123 > hadooplibs/hadoop-distcp-2/pom.xml 7971eb5 > hadooplibs/hadoop-distcp-3/pom.xml 598ee13 > hadooplibs/hadoop-test-0.23/pom.xml addcd11 > hadooplibs/hadoop-test-1/pom.xml baf5a4c > hadooplibs/hadoop-test-2/pom.xml 027c813 > hadooplibs/hadoop-test-3/pom.xml 7176f51 > hadooplibs/hadoop-utils-0.23/pom.xml 91985fc > > hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > 46c2fbd > > hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > 9a19770 > hadooplibs/hadoop-utils-1/pom.xml c81ea91 > hadooplibs/hadoop-utils-2/pom.xml 2d3dbdd > hadooplibs/hadoop-utils-3/pom.xml 7270bfd > hadooplibs/pom.xml e5ea2e7 > hbaselibs/hbase-0.94/pom.xml a65904e > hbaselibs/pom.xml 24051c5 > hcataloglibs/hive-hcatalog-0.13.1/pom.xml b738741 > hcataloglibs/pom.xml a96806b > minitest/pom.xml 8f656d2 > pom.xml 5507381 > sharelib/distcp/pom.xml b788ed0 > sharelib/hcatalog/pom.xml b934be1 > sharelib/hive/pom.xml ea088ff > sharelib/hive2/pom.xml e4c2465 > sharelib/oozie/pom.xml 053cf1c > sharelib/pig/pom.xml ce75c68 > sharelib/spark/pom.xml 744c95c > sharelib/sqoop/pom.xml 09f0b66 > sharelib/streaming/pom.xml 50d15f7 > src/main/assemblies/distro.xml 8e2bbae > src/main/assemblies/hadooplib.xml b32ca82 > src/main/assemblies/hadooplibs.xml 9884efa > src/main/assemblies/hbaselib.xml 6e4db33 > src/main/assemblies/hbaselibs.xml eb71624 > src/main/assemblies/hcataloglib.xml 1002308 > src/main/assemblies/hcataloglibs.xml 3d32a8f > tools/pom.xml 80fa425 > tools/src/main/bin/ooziedb.sh 68158d8 > webapp/pom.xml a410b10 > zookeeper-security-tests/pom.xml b24ce33 > > Diff: https://reviews.apache.org/r/22615/diff/ > > > Testing > ------- > > Clean build with different hive and hbase versions > > > Thanks, > > shwethags > >
