----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28290/#review64100 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java <https://reviews.apache.org/r/28290/#comment106524> This is inefficient. Start with min(4, actual range count) as the size, then exponentially increase, but keep limit fixed at 200. core/src/main/java/org/apache/oozie/dependency/FSURIHandler.java <https://reviews.apache.org/r/28290/#comment106525> Do not do this for fs. Unnecessary checks when not required if we are not using fs liststatus or globbing. Have a supportsBatchExists() method which will return false for FSUriHandler and if that is the case go with the old logic. core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java <https://reviews.apache.org/r/28290/#comment106533> Need to use > or < when possible (YYYYMMDD, YYYYMMDDHH, etc patterns). OR is not efficient and will still put lot of load on hcat server core/src/test/java/org/apache/oozie/dependency/TestHCatURIHandler.java <https://reviews.apache.org/r/28290/#comment106551> Have a extra partition "state" which is not used in the uri template. Users have a lot of partition, but mostly one use 1 or 2 in the uri template. - Rohini Palaniswamy On Nov. 20, 2014, 6:54 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28290/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2014, 6:54 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2070 > https://issues.apache.org/jira/browse/OOZIE-2070 > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-2070 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 7f59186 > core/src/main/java/org/apache/oozie/dependency/FSURIHandler.java 7c1aadf > core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java 0e690a0 > core/src/main/java/org/apache/oozie/dependency/URIHandler.java 6e54d4b > core/src/main/resources/oozie-default.xml 19cae9d > > core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java > f79c9a0 > core/src/test/java/org/apache/oozie/dependency/TestFSURIHandler.java > 75d5429 > core/src/test/java/org/apache/oozie/dependency/TestHCatURIHandler.java > a49eba5 > core/src/test/java/org/apache/oozie/test/MiniHCatServer.java 8699ff8 > core/src/test/java/org/apache/oozie/test/XHCatTestCase.java 85ee1f2 > > Diff: https://reviews.apache.org/r/28290/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
