> On Dec. 11, 2014, 9:21 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, > > line 242 > > <https://reviews.apache.org/r/28637/diff/3/?file=785337#file785337line242> > > > > I think it actually makes sense and whatever I thought might conflict > > would be ok. Could you still add a config > > oozie.launcher.only.job.copy.actionconf (or some better name) as bother > > server and action level config with default value as true, so that we can > > turn it off in production if some unexpected conflict rises. If only few > > users encounter issue we can ask them to override at action level and if > > there is a major issue can turn it off at server level itself.
Will do > On Dec. 11, 2014, 9:21 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java, > > line 180 > > <https://reviews.apache.org/r/28637/diff/3/?file=785338#file785338line180> > > > > Based on the code in LiteWorkflowAppParser.handleGlobal, > > eConf.getChild("configuration", ns) should contain the global > > configuration. Instead of parsing global and jobxml again, you could just > > use that. > > > > I think the cleaner way to do this would be to not touch > > ActionExecutors at all. Should parse and store global configuration in > > WorkflowInstance once and add it to each action configuration and also > > initialize global configuration of sub WorkflowInstance created with it. > > Currently the global section and its job.xml is parsed for each action > > which is really bad for latency. This would also take care of propagating > > it to nested sub-workflows. If the sub-workflow had global configuration > > then that should be merged while parsing itself to the parent global config > > initialized. Makes sense. But that change will be more involved. Lets track that in another jira - shwethags ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28637/#review64788 ----------------------------------------------------------- On Dec. 8, 2014, 7:20 a.m., shwethags wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28637/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2014, 7:20 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2030 > https://issues.apache.org/jira/browse/OOZIE-2030 > > > Repository: oozie-git > > > Description > ------- > > 1. Propagate properties from configuration and job-xml from parent workflow > to sub-workflow. Currently, its propagated as workflow properties, but they > are required in action conf > 2. For java actions, add properties from configuration and job-xml to > launcher job > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/ActionExecutor.java ff836fb > core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java > fed1d7a > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > f207d74 > > core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java > bda34b5 > core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java > 18de48a > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 48166a5 > > core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java > 0d7e926 > examples/src/main/apps/subwf/job.xml PRE-CREATION > examples/src/main/apps/subwf/workflow.xml 9873a50 > > Diff: https://reviews.apache.org/r/28637/diff/ > > > Testing > ------- > > UTs and end to end test > > > Thanks, > > shwethags > >
