[ 
https://issues.apache.org/jira/browse/OOZIE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349729#comment-14349729
 ] 

Purshotam Shah commented on OOZIE-2142:
---------------------------------------

{code}
+                case ERROR:
+                    // If allowed to retry, this will handle it; otherwise, we 
should fall through to FAILED
+                    if (handleUserRetry(wfAction)) {
+                        break;
+                    }
                 case FAILED:
{code}
failJob() function also calls handleUserRetry, so we might be calling 
handleUserRetry twice. No harm, but we can optimized it.
May be better option is
{code}                
                case FAILED:                
                case ERROR:
                    failJob(context, wfAction);
                    generateEvent = true;
                    break;
{code}

> Changing the JT whitelist causes running Workflows to stay RUNNING forever
> --------------------------------------------------------------------------
>
>                 Key: OOZIE-2142
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2142
>             Project: Oozie
>          Issue Type: Bug
>          Components: core
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>         Attachments: OOZIE-2142.patch
>
>
> If you change the JT whitelist while a workflow is running (and restart 
> Oozie), that workflow will stay RUNNING forever.  The correct behavior should 
> be the same as if the JT is unavailable: Oozie retries a few times and 
> SUSPENDs the workflow.  Then the user should either put it back into the 
> whitelist and resume, or simply kill it.
> There might be multiple ways to reproduce, but here's one:
> # Submit a workflow that has enough actions to run for a while
> # Suspend the workflow
> # Change the JT whitelist
> # Restart Oozie
> # Resume the workflow
> You'll get errors about the whitelist, but it won't ever transition out of 
> RUNNING



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to