----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31687/#review75495 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java <https://reviews.apache.org/r/31687/#comment122616> element.getChildTextTrim(ATTACHMENT, ns) -> attachment core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java <https://reviews.apache.org/r/31687/#comment122617> You should not be allowing local file attachment. I can use that to fetch a password file on the Oozie server host and is a security risk. docs/src/site/twiki/DG_EmailActionExtension.twiki <https://reviews.apache.org/r/31687/#comment122618> [COMMA-SEPARATED-HDFS-FILE-PATHS] docs/src/site/twiki/DG_EmailActionExtension.twiki <https://reviews.apache.org/r/31687/#comment122619> Correction of plural usage The =attachment= is used to attach HDFS file(s) to the mail. Multiple attachments can be - Rohini Palaniswamy On March 5, 2015, 1:45 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31687/ > ----------------------------------------------------------- > > (Updated March 5, 2015, 1:45 p.m.) > > > Review request for oozie. > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-2160 > > > Diffs > ----- > > client/src/main/resources/email-action-0.2.xsd 60ce545 > core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java > 21c6313 > > core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java > ec8cf71 > > core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java > e1f314e > docs/src/site/twiki/DG_EmailActionExtension.twiki 695e16b > > Diff: https://reviews.apache.org/r/31687/diff/ > > > Testing > ------- > > test done. tested in QE enviornment with real HDFS > > > Thanks, > > Ryota Egashira > >
