[ 
https://issues.apache.org/jira/browse/OOZIE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386925#comment-14386925
 ] 

Rohini Palaniswamy commented on OOZIE-1624:
-------------------------------------------

bq. can we cache regex exclusion pattern to map
   It should be fine. Since it is called only twice per action (system lib and 
share lib) and will only be used rarely it should be fine. May be cache as a 
non-static variable to avoid doing it twice per action and once instead. 

bq. isExclude(fileName, exclusionPattern)
   Please do pattern matching for the entire file name instead of just the 
filename. For eg: if you have two pig.jar and you want to exclude pig.jar from 
one directory

bq. One can also exclude sharelib jars by using property 
action.sharelib.for.#ACTIONTYPE#.exclusion. Any sharelib jar which matches the 
pattern will not be included.
 Please add an example here. Also mention that the regex matching is based on 
https://docs.oracle.com/javase/7/docs/api/java/util/regex/Pattern.html. 

> Exclusion pattern for sharelib.
> -------------------------------
>
>                 Key: OOZIE-1624
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1624
>             Project: Oozie
>          Issue Type: Sub-task
>            Reporter: Purshotam Shah
>            Assignee: Purshotam Shah
>         Attachments: OOZIE-1624-V2.patch, OOZIE-1624-v1.patch
>
>
> Sharelib may bring some jar which might conflict with user jars.
> Ex. Sharelib hive has json-2.xxxx.jar, where as some of the user use-case 
> need higher version of json jar.
> He should be able to exclude sharelib json jar and bring his own version.
> <property>
>         <name>oozie.action.sharelib.for.hive.exclusion</name>
>         <value>json-\*.jar|abc-*.jar</value>
>  </property>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to